Update dependency golangci/golangci-lint to v1.59.1

[renovate-rancher]

This PR contains the following updates:

Package	Update	Change
golangci/golangci-lint	minor	v1.57.1 -> v1.59.1

---

Release Notes

golangci/golangci-lint (golangci/golangci-lint)

v1.59.1

Compare Source

1. Updated linters
   • go-errorlint: from 1.5.1 to 1.5.2
   • gomnd: deprecated configuration compatibility
   • intrange: add style preset
   • misspell: from 0.5.1 to 0.6.0
   • sloglint: from 0.7.0 to 0.7.1
   • testifylint: from 1.3.0 to 1.3.1
   • unparam: bump to HEAD
   • usestdlibvars: from 1.25.0 to 1.26.0
2. Fixes
   • SARIF: init empty result slice
   • SARIF: issue column >= 1
3. Documentation
   • update revive configuration

v1.59.0

Compare Source

1. Enhancements
   • Add SARIF output format
   • Allow the analysis of generated files (issues.exclude-generated: disable)
2. Updated linters
   • errcheck: fix deprecation warning
   • go-critic: from 0.11.3 to 0.11.4
   • gosec: from 2.20.0 to 5f0084e (fix G601 and G113 performance issues)
   • sloglint: from 0.6.0 to 0.7.0 (new option forbidden-keys)
   • testifylint: from 1.2.0 to 1.3.0 (new checker negative-positive and new option go-require.ignore-http-handlers)
3. Misc.
   • ️️⚠️ Deprecate github-action output format
   • ️️⚠️ Deprecate issues.exclude-generated-strict option (replaced by issues.exclude-generated: strict)
   • ️️⚠️ Add warning about disabled and deprecated linters (level 2)

v1.58.2

Compare Source

1. Updated linters
   • canonicalheader: from 1.0.6 to 1.1.1
   • gosec: from 2.19.0 to 2.20.0
   • musttag: from 0.12.1 to 0.12.2
   • nilnil: from 0.1.8 to 0.1.9
2. Documentation
   • Improve integrations and install pages

v1.58.1

Compare Source

1. Updated linters
   • tagalign: from 1.3.3 to 1.3.4
   • protogetter: from 0.3.5 to 0.3.6
   • gochecknoinits: fix analyzer name
2. Fixes
   • Restores previous gihub-actions output format (removes GitHub Action problem matchers)

v1.58.0

Compare Source

1. New linters
   • fatcontext: https://github.com/Crocmagnon/fatcontext
   • canonicalheader: https://github.com/lasiar/canonicalheader
2. Updated linters
   • copyloopvar: from 1.0.10 to 1.1.0 (ignore-alias is replaced by check-alias with the opposite behavior)
   • decorder: from 0.4.1 to 0.4.2
   • errname: from 0.1.12 to 0.1.13
   • errorlint: from 1.4.8 to 1.5.1 (new options allowed-errors and allowed-errors-wildcard)
   • execinquery: deprecate linter ⚠️
   • gci: from 0.12.3 to 0.13.4 (new section localModule)
   • gocritic: from 0.11.2 to 0.11.3
   • spancheck: from 0.5.3 to 0.6.1
   • goerr113 is replaced by err113 ⚠️
   • gomnd is replaced by mnd ⚠️
   • gomodguard: from 1.3.1 to 1.3.2
   • grouper: from 1.1.1 to 1.1.2
   • intrange: from 0.1.1 to 0.1.2
   • mirror: from 1.1.0 to 1.2.0
   • misspell: from 0.4.1 to 0.5.1
   • musttag: from 0.9.0 to 0.12.1
   • nilnil: from 0.1.7 to 0.1.8
   • nonamedreturns: from 1.0.4 to 1.0.5
   • promlinter: from 0.2.0 to 0.3.0
   • sloglint: from 0.5.0 to 0.6.0
   • unparam: bump to HEAD (063aff9)
   • whitespace: from 0.1.0 to 0.1.1
3. Enhancements
   • Speed up "fast" linters when only "fast" linters are run: between 40% and 80% faster at first run (i.e. without cache)
4. Fixes
   • Use version with module plugins
   • Skip go.mod report inside autogenerated processor
   • Keep only typecheck issues when needed
   • Don't hide typecheck errors inside diff processor
5. Misc.
   • ⚠️ log an error when using previously deprecated linters (Linter Deprecation Cycle)
     • deadcode: deprecated since v1.49.0 (2022-08-23).
     • exhaustivestruct: deprecated since v1.46.0 (2022-05-08).
     • golint: deprecated since v1.41.0 (2021-06-15).
     • ifshort: deprecated since v1.48.0 (2022-08-04).
     • interfacer: deprecated since v1.38.0 (2021-03-03).
     • maligned: deprecated since v1.38.0 (2021-03-03).
     • nosnakecase: deprecated since v1.48.0 (2022-08-04).
     • scopelint: deprecated since v1.39.0 (2021-03-25).
     • structcheck: deprecated since v1.49.0 (2022-08-23).
     • varcheck: deprecated since v1.49.0 (2022-08-23).
   • ⚠️ Deprecate usage of linter alternative names
   • Remove help display on errors with config verify command
   • Add pre-commit hook to run config verify
   • Improve github-action output
6. Documentation
   • Remove deprecated Atom from Editor Integrations

GitHub Action (v5.1.0) for golangci-lint:

• supports for pull, pull_request_target, and merge_group events with the option only-new-issues.
• ️️⚠️ skip-pkg-cache and skip-build-cache have been removed because the cache related to Go itself is already handled by actions/setup-go.
• with golangci-lint v1.58, the file information (path and position) will be displayed on the log.

v1.57.2

Compare Source

1. Updated linters
   • contextcheck: from 1.1.4 to 1.1.5
   • copyloopvar: from 1.0.8 to 1.0.10
   • ginkgolinter: from 0.16.1 to 0.16.2
   • goconst: from 1.7.0 to 1.7.1
   • gomoddirectives: from 0.2.3 to 0.2.4
   • intrange: from 0.1.0 to 0.1.1
2. Misc.
   • Display warnings on deprecated linter options
   • Fix missing colored-tab output format
   • Fix TeamCity inspectionType service message
3. Documentation
   • Remove invalid example about mixing files and directory
   • Improve linters page

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[JonCrowther]

We don't seem to use testify, so aren't affected by the breaking change

[crobby]

rekicked ci, but might need a rebase after webhook was moved to 1.22

[tomleb]

rekicked ci, but might need a rebase after webhook was moved to 1.22

@crobby It won't succeed because there are changes needed to be compliant with this new version of golangci-lint. @JonCrowther has opened a separate PR to do the golangci-lint bump + the changes to make it compliant.

I assume he'll close this issue here once that goes in.

[ericpromislow]

The change to .drone.yml in unrelated PR #366 fixes the CI failure here