Add a check for the agent-tls-mode setting #416
+457
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonCrowther
reviewed
Jul 2, 2024
| @@ -129,3 +164,21 @@ func validateDuration(value string) (time.Duration, error) { | |||
|
|
|||
| return dur, err | |||
| } | |||
|
|
|||
| func clusterConditionMatches(cluster *v3.Cluster, t v3.ClusterConditionType, status v1.ConditionStatus) bool { | |||
There was a problem hiding this comment.
I appreciate the tests on effectiveValue, I think for the sake of completeness we could add a test for clusterConditionMatches too
ericpromislow
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#45589
Problem
The webhook needs to validate updates to the
agent-tls-modesetting given the logic below.Solution
If
agent-tls-modehasdefaultorvalueupdated fromsystem-storetostrict, then all non-local clusters musthave a status condition
AgentTlsStrictCheckset toTrue, unless the new setting has an overridingannotation
cattle.io/force=true.CheckList