Remove unused setuptools dependencies
#62
Assignees
Comments
|
After a search of the I've updated the task list in the description, and I'll put up PRs for all of those today. |
This was referenced May 28, 2024
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this issue
May 30, 2024
Contributes to rapidsai/build-planning#62. It looks like this project's wheels and conda recipes have unnecessary dependencies on `setuptools`. I suspect those are left over from before the project was cut over to `scikit-build-core`. This proposes removing those. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mark Harris (https://github.com/harrism) - Jake Awe (https://github.com/AyodeAwe) URL: #1389
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this issue
May 30, 2024
Contributes to rapidsai/build-planning#62. It looks like this some of the `kvikio` conda package recipe has an unnecessary dependency on `setuptools`. I suspect that's left over from before the project was cut over to `scikit-build-core`. This proposes removing it. ## Notes for Reviewers How I confirmed there were no direct uses of `setuptools` in this project: ```shell git grep -i setuptools ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #385
rapids-bot bot
pushed a commit
to rapidsai/raft
that referenced
this issue
May 30, 2024
Contributes to rapidsai/build-planning#62. It looks like this some of this project's `conda` recipes have unnecessary dependencies on `setuptools`. I suspect those are left over from before the project was cut over to `scikit-build-core`. ## Notes for Reviewers How I confirmed there were no direct uses of `setuptools` in `pylibraft` and `raft-dask`: ```shell git grep -i setuptools ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #2343
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this issue
May 30, 2024
Contributes to rapidsai/build-planning#62. It looks like the `cugraph` and `pylibcugraph` wheels and conda recipes have unnecessary dependencies on `setuptools` and `wheel`. I suspect those are left over from before those libraries were cut over to `scikit-build-core`. This proposes removing those. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Jake Awe (https://github.com/AyodeAwe) - Rick Ratzel (https://github.com/rlratzel) URL: #4448
|
I did one more quick GitHub search, don't see any other cases that need to be addressed. This is complete 😁 |
|
Thanks James! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Working on #31, I found that
cudfwas carrying a dependency onsetuptoolsthat it didn't need. See rapidsai/cudf#15736.Noticed something similar in
cumltoday: rapidsai/cuml#5901.I suspect there might be other RAPIDS libraries that also have an unnecessary
setuptoolsdependency, left over from earlier approaches to building them.Benefits of this work
Acceptance Criteria
setuptoolsdependency across RAPIDS is usedApproach
Browse through https://github.com/search?q=org%3Arapidsai%20setuptools&type=code.
Repos with
setuptoolsdeclared only in conda build recipes ordependencies.yaml(i.e. never directly imported, not referenced in[build-system]table inpyproject.toml) are good candidates. Add a tasklist here listing the repos to investigate.For any repos that look like they're carrying around unnecessary
setuptoolsdependencies, remove those dependencies.Notes
cudf(remove unnecessary 'setuptools' host dependency, simplify dependencies.yaml cudf#15736)cuml(remove unnecessary 'setuptools' dependency cuml#5901)cugraph(remove unnecessary 'setuptools' and 'wheel' dependencies cugraph#4448)cuspatial(remove unnecessary 'setuptools' dependencies cuspatial#1389)kvikio(remove unnecessary 'setuptools' dependency kvikio#385)raft(remove unnecessary 'setuptools' dependencies raft#2343)The text was updated successfully, but these errors were encountered: