use rapids-build-backend #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
bdice
approved these changes
Jun 5, 2024
grlee77
approved these changes
Jun 6, 2024
Comment on lines
+290
to
+293
| - &cupy_cu11 cupy-cuda11x>=12.0.0 | ||
| - matrix: | ||
| packages: | ||
| - *cupy_cu11 |
There was a problem hiding this comment.
unfamiliar with the notation, curious what the & and * in the package names do here?
There was a problem hiding this comment.
These are YAML anchors. We defined an anchor with & and reused its value with *.
There was a problem hiding this comment.
oh sure, happy to explain! This is a YAML "alias", pointing to a YAML "anchor". When this document is loaded, *cupy_cu11 will be replaced with whatever value is tagged with &cupy_cu11. It's a way to reduce a bit of duplication, to keep things that should be consistent consistent.
For example, this:
limits:
cpu: 1.0
requests:
cpu: 1.0Is identical to this:
limits:
cpu: &cpu_val 1.0
requests:
cpu: *cpu_valFor reference, see:
raydouglass
approved these changes
Jun 7, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89
Proposes introducing
rapids-build-backendas this project's build backend, to reduce the complexity of various CI/build scripts.