Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flatbuffers to libcudf build #16446

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

galipremsagar
Copy link
Contributor

Description

Without flatbuffers being added to the conda environment libcudf is being built in is causing the following build failures:

In file included from /nvme/0/pgali/cudf/cpp/src/io/parquet/arrow_schema_writer.cpp:26:
/nvme/0/pgali/cudf/cpp/src/io/parquet/ipc/Message_generated.h:6:10: fatal error: flatbuffers/flatbuffers.h: No such file or directory
    6 | #include <flatbuffers/flatbuffers.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar self-assigned this Jul 31, 2024
@galipremsagar galipremsagar requested review from a team as code owners July 31, 2024 15:12
@galipremsagar galipremsagar requested review from AyodeAwe, bdice, mroeschke and JayjeetAtGithub and removed request for a team July 31, 2024 15:12
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Jul 31, 2024
@github-actions github-actions bot removed libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. CMake CMake build issue pylibcudf Issues specific to the pylibcudf package labels Jul 31, 2024
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Jul 31, 2024
dependencies.yaml Outdated Show resolved Hide resolved
conda/recipes/libcudf/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@mhaseeb123 mhaseeb123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies.yaml Outdated Show resolved Hide resolved
conda/recipes/libcudf/meta.yaml Outdated Show resolved Hide resolved
conda/environments/all_cuda-125_arch-x86_64.yaml Outdated Show resolved Hide resolved
conda/environments/all_cuda-118_arch-x86_64.yaml Outdated Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

Should we specify the flatbuffers version to the same in https://github.com/rapidsai/cudf/blob/branch-24.10/cpp/cmake/thirdparty/get_flatbuffers.cmake#L33

Yes! Done 👍

@bdice
Copy link
Contributor

bdice commented Jul 31, 2024

I verified that this fix is necessary and should be included in 24.08. We were shipping flatbuffers headers in the libcudf package (see related issue #13230). That can clobber the actual flatbuffers package, if it installed in the user's conda env.

@AyodeAwe AyodeAwe merged commit 9f5e4a3 into rapidsai:branch-24.08 Jul 31, 2024
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants