Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make more use of YAML anchors in dependencies.yaml #16597

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#33

Follow-up to #16299

This proposes some simplifications to dependencies.yaml. It's not intended to change any behavior.

  • more use of YAML anchors for requirements that are intended to be identical to each other
  • eliminating the pylibcudf_build_dep dependency group that was introduced in Setup pylibcudf package #16299, in favor of just tracking the pylibcudf build dependency alongside cudf's rmm build dependency in the existing build_python_cudf group

I found myself starting to make similar changes in the PR breaking up these packages into more (splitting out a libcudf in #15483) and thought they'd be better as a standalone PR.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 19, 2024
@jameslamb jameslamb changed the title WIP: make more use of YAML anchors in dependencies.yaml make more use of YAML anchors in dependencies.yaml Aug 19, 2024
@jameslamb jameslamb marked this pull request as ready for review August 19, 2024 18:04
@jameslamb jameslamb requested a review from a team as a code owner August 19, 2024 18:04
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f2d13c9 into rapidsai:branch-24.10 Aug 19, 2024
92 of 94 checks passed
@jameslamb jameslamb deleted the yaml-anchors branch August 19, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants