Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix libcudf wheel publishing, make package-type explicit in wheel publishing #16650

Merged

Conversation

jameslamb
Copy link
Member

Description

Follow-up to #15483.

Contributes to rapidsai/build-planning#33

Wheel publishing for libcudf is failing like this:

Error:  File "./dist/*.whl" does not exist

(build link)

Because the package-type was not set to cpp in the wheels-publish CI workflow, and that workflow defaults to python. (shared-workflows code link).

This fixes that, and makes that choice explicit for all wheel publishing jobs.

References for this package-type argument:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added bug Something isn't working non-breaking Non-breaking change labels Aug 23, 2024
@jameslamb jameslamb requested review from vyasr and bdice August 23, 2024 17:53
@jameslamb jameslamb requested a review from a team as a code owner August 23, 2024 17:53
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fan of making this explicit everywhere over the course of the C++ wheels work and eventually making it a required parameter.

@KyleFromNVIDIA
Copy link
Contributor

I'd be fan of making this explicit everywhere over the course of the C++ wheels work and eventually making it a required parameter.

Same here.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 7ca6a8c into rapidsai:branch-24.10 Aug 23, 2024
84 checks passed
@jameslamb jameslamb deleted the fix/libcudf-wheel-publishing branch August 23, 2024 20:54
rapids-bot bot pushed a commit that referenced this pull request Aug 31, 2024
Follow-up to #16650 and #15483.

`libcudf` wheels are identical (same content, same filename) across Python versions, but due to an oversight in the PRs linked above, we're currently building nightlies of them once per Python version supported by RAPIDS 😭 

You can see this on recent runs of the `build` workflow:

<img width="752" alt="image" src="https://github.com/user-attachments/assets/ba3a2192-1752-4d32-a79b-6f238fae9f18">

([build link](https://github.com/rapidsai/cudf/actions/runs/10627299703/job/29460218854))

This PR fixes that by applying the same matrix filter to `libcudf` nightly build jobs as is currently applied to PR jobs:

https://github.com/rapidsai/cudf/blob/5e420ff63ba2997a37bf5dfbfaa73c5f05225f9d/.github/workflows/pr.yaml#L195-L200

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Bradley Dice (https://github.com/bdice)

URL: #16714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants