-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support rapids-build-backend #325
Merged
trxcllnt
merged 14 commits into
rapidsai:branch-24.08
from
jameslamb:rapids-build-backend
Jun 14, 2024
Merged
support rapids-build-backend #325
trxcllnt
merged 14 commits into
rapidsai:branch-24.08
from
jameslamb:rapids-build-backend
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
reviewed
Jun 11, 2024
features/src/rapids-build-utils/opt/rapids-build-utils/bin/tmpl/python.build.wheel.tmpl.sh
Outdated
Show resolved
Hide resolved
jameslamb
commented
Jun 12, 2024
features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml
Outdated
Show resolved
Hide resolved
edit: fixed the git history |
…gs in manifest.yaml
…t.yaml Co-authored-by: James Lamb <[email protected]>
trxcllnt
force-pushed
the
rapids-build-backend
branch
from
June 12, 2024 20:14
f44a7b3
to
1c420c5
Compare
trxcllnt
approved these changes
Jun 13, 2024
jameslamb
changed the title
WIP: [NOT READY FOR REVIEW] support rapids-build-backend
WIP: support rapids-build-backend
Jun 13, 2024
jameslamb
added
improvement
Improves an existing functionality
non-breaking
Introduces a non-breaking change
labels
Jun 13, 2024
jameslamb
changed the title
WIP: support rapids-build-backend
support rapids-build-backend
Jun 13, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#31
rapids-build-backend
flags for pip buildsrapids-python-uses-scikit-build-core
to correctly detectscikit-build-core
even whenrapids-build-backend
is the top-level build-backendHow I tested this
Rebuilt the container, then ran the following in the CUDA 12.2 pip container.
Saw that all succeed.