Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rapids-build-backend #325

Merged
merged 14 commits into from
Jun 14, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jun 11, 2024

Contributes to rapidsai/build-planning#31

  • adds rapids-build-backend flags for pip builds
  • updates rapids-python-uses-scikit-build-core to correctly detect scikit-build-core even when rapids-build-backend is the top-level build-backend

How I tested this

Rebuilt the container, then ran the following in the CUDA 12.2 pip container.

# clean previous build outputs
uninstall-all -j
clean-all -j

# work on latest branches of everything
rapids-checkout-same-branch --omit ucxx
git -C ./ucxx checkout branch-0.39
rapids-pull-repositories

# install all the other dependencies
rapids-make-pip-env --force

# build all the packages
build-all -j

# run the cudf unit tests
cd ./cudf
./ci/run_cudf_pytests.sh

# run the cuml unit tests
cd ./cuml
./ci/run_cuml_singlegpu_pytests.sh

Saw that all succeed.

@trxcllnt
Copy link
Collaborator

trxcllnt commented Jun 12, 2024

Looks like I messed up the history trying to rebase out the commits from main. Luckily this will go away when we squash!

edit: fixed the git history

@jameslamb jameslamb changed the title WIP: [NOT READY FOR REVIEW] support rapids-build-backend WIP: support rapids-build-backend Jun 13, 2024
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 13, 2024
@jameslamb jameslamb marked this pull request as ready for review June 13, 2024 21:35
@jameslamb jameslamb changed the title WIP: support rapids-build-backend support rapids-build-backend Jun 13, 2024
@jameslamb
Copy link
Member Author

/merge

@trxcllnt trxcllnt merged commit ecfaa57 into rapidsai:branch-24.08 Jun 14, 2024
196 checks passed
@jameslamb jameslamb deleted the rapids-build-backend branch June 14, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants