Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nvcomp package #242

Closed
jakirkham opened this issue Jun 13, 2023 · 0 comments · Fixed by #245
Closed

Use nvcomp package #242

jakirkham opened this issue Jun 13, 2023 · 0 comments · Fixed by #245

Comments

@jakirkham
Copy link
Member

Currently nvCOMP is fetched by CMake

kvikio/python/cmake/CMakeLists.txt

Line 15 in d9eee8b

include(thirdparty/get_nvcomp.cmake)

Now that there is an nvcomp conda package, it would be good to switch over to using that instead
@jakirkham jakirkham mentioned this issue Jun 13, 2023
Open
@bdice bdice mentioned this issue Jun 14, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #245 Jun 26, 2023
rapids-bot bot pushed a commit that referenced this issue Jun 26, 2023
@bdice
Use nvcomp conda package. (#245)
1ffe8b1 
This PR uses conda-forge packages of `nvcomp` rather than fetching a tarball. This means that the nvcomp binary should not be shipped in the kvikio conda package, but is instead listed as a dependency. This will reduce kvikio's conda package size.

Resolves #242.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/jakirkham
  - Ray Douglass (https://github.com/raydouglass)

URL: #245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use nvcomp conda package. bdice/kvikio
1 participant
@jakirkham