Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rapids-build-backend #389

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#31
Contributes to rapidsai/dependency-file-generator#89

Proposes introducing rapids-build-backend as this project's build backend, to reduce the complexity of various CI/build scripts.

Notes for Reviewers

What about the ongoing work to add wheels?

If #369 is merged before this, this should be updated to ensure it doesn't break wheel builds.

But opening this one separately so we can keep making forward progress on rolling out rapids-build-backend across RAPIDS.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jun 5, 2024
@jameslamb jameslamb changed the title WIP: use rapids-build-backend use rapids-build-backend Jun 6, 2024
@jameslamb jameslamb marked this pull request as ready for review June 6, 2024 14:41
@jameslamb jameslamb requested review from a team as code owners June 6, 2024 14:41
@jameslamb jameslamb requested a review from bdice June 6, 2024 16:59
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@jameslamb jameslamb requested review from a team as code owners June 10, 2024 13:47
@jameslamb jameslamb requested review from raydouglass and removed request for a team June 10, 2024 13:47
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit e460b16 into rapidsai:branch-24.08 Jun 10, 2024
35 checks passed
@jameslamb jameslamb deleted the rapids-build-backend branch June 10, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants