Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several issues with wheel builds #439

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Fix several issues with wheel builds #439

merged 4 commits into from
Aug 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

  • Ensure correct directory layout in both wheels
  • Add CMake entry point to libkvikio wheel
  • Require kvikio wheel to use libkvikio wheel
  • Exclude unneeded source files from wheel

@KyleFromNVIDIA
Fix several issues with wheel builds
fd578a0 
* Ensure correct directory layout in both wheels
* Add CMake entry point to libkvikio wheel
* Require kvikio wheel to use libkvikio wheel
* Exclude unneeded source files from wheel
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners August 16, 2024 16:35
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Introduces a non-breaking change labels Aug 16, 2024
jameslamb
jameslamb approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes all make sense to me, thanks

python/libkvikio/pyproject.toml Show resolved Hide resolved
python/kvikio/pyproject.toml Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

cc @msarahan

msarahan
msarahan approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fixes! Thanks.

vyasr
vyasr reviewed Aug 16, 2024
View reviewed changes
python/kvikio/pyproject.toml Outdated Show resolved Hide resolved
ci/build_wheel_python.sh Outdated Show resolved Hide resolved
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 56d859e into rapidsai:branch-24.10 Aug 16, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@msarahan msarahan msarahan approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@vyasr vyasr vyasr approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleFromNVIDIA @msarahan @robertmaynard @vyasr @jameslamb