Add verify-alpha-spec hook #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
The implementation looks good. I validated the logic, but didn't check that all the YAML tags were right; I'm trusting the tests to do that since the tests also look correct. It's probably worth getting one more set of eyes on this PR, but it generally looks right to me. We have to figure out where we're going to put this to run in release mode, though.
bdice
reviewed
May 21, 2024
vyasr
requested changes
May 23, 2024
3 tasks
bdice
requested changes
May 28, 2024
bdice
requested changes
May 28, 2024
bdice
approved these changes
May 28, 2024
vyasr
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rapids-build-backend invoking rapids-dependency-file-generator, we want all dependencies to have the alpha spec (
>=0.0..0a0) so that we don't have to usesedto add it. Add a hook to enforce this (and to enforce removing it for production).