Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Benchmark CAGRA select_k #1601

Draft
wants to merge 3 commits into
base: branch-24.04
Choose a base branch
from

Conversation

benfred
Copy link
Member

@benfred benfred commented Jun 22, 2023

No description provided.

@benfred benfred requested a review from a team as a code owner June 22, 2023 17:29
@benfred benfred marked this pull request as draft June 22, 2023 17:29
@github-actions github-actions bot added the cpp label Jun 22, 2023
@benfred
Copy link
Member Author

benfred commented Jun 22, 2023

Running ./cpp/build/MATRIX_BENCH --benchmark_filter=SelectKDataset/float/int64_t/kCagra/146/9594063/256/0/1/manual_time --benchmark_out_format=json --benchmark_out=select_k_times.json --select_k_dataset on this branch produces memory access errors like

=========     at 0x3ee0 in /home/ben/code/raft/cpp/include/raft/neighbors/detail/cagra/topk_for_cagra/topk_core.cuh:611:void raft::neighbors::experimental::cagra::detail::topk_cta_11_core<(int)1024, (int)8, (int)1, (int)256, (int)64, long>(unsigned int, unsigned int, const unsigned int *, const T6 *, unsigned int *, T6 *, unsigned char *, unsigned int *, bool, unsigned int *)
=========     by thread (155,0,0) in block (138,0,0)
=========     Address 0x7f66cc56f388 is out of bounds
=========     and is 694,750,328 bytes before the nearest allocation at 0x7f66f5c00000 of size 102,400 bytes
=========     Device Frame:/home/ben/code/raft/cpp/include/raft/neighbors/detail/cagra/topk_for_cagra/topk_core.cuh:784:void raft::neighbors::experimental::cagra::detail::kern_topk_cta_11<(int)1024, (int)8, (int)1, (int)256, (int)64, long>(unsigned int, unsigned int, unsigned int, const unsigned int *, unsigned int, const T6 *, unsigned int, unsigned int *, unsigned int, T6 *, unsigned int, unsigned char *, unsigned int *, bool) [0x13c0]

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 22, 2023
@benfred benfred changed the title [WIP} Benchmark CAGRA select_k [WIP] Benchmark CAGRA select_k Jun 23, 2023
Copy link

copy-pr-bot bot commented Nov 8, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@benfred benfred changed the base branch from branch-23.08 to branch-22.12 November 8, 2023 00:48
@github-actions github-actions bot added the gpuCI label Nov 8, 2023
@benfred benfred changed the base branch from branch-22.12 to branch-23.12 November 8, 2023 00:52
@benfred benfred changed the base branch from branch-23.12 to branch-24.02 December 12, 2023 19:26
@benfred benfred changed the base branch from branch-24.02 to branch-24.04 January 23, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cpp gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants