Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure update-version.sh preserves alpha spec, add tests on version constants #2344

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31

Follow-up to #2331

  • ensures that update-version.sh does not remove alpha specs like ,>=0.0.0a0 in pyproject.toml and conda environment files
  • consolidates rapids-build-backend versions in dependencies.yaml
  • adds tests that __git_commit__ and __version__ constants are present and that __version__ is populated

@jameslamb jameslamb added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 29, 2024
@jameslamb jameslamb requested review from a team as code owners May 29, 2024 22:55
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit f690e5c into rapidsai:branch-24.08 Jun 4, 2024
69 checks passed
@jameslamb jameslamb deleted the more-rbb branch June 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants