-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always download repos when they are being patched #525
Always download repos when they are being patched #525
Conversation
6d19aac
to
06b9467
Compare
@robertmaynard this is close, but there is an issue with passing an empty patch command. The issue comes from passing empty strings to |
@vyasr I tried playing around as well and I don't see a great solution to this. I think we are going to do is change around That would mean a change to each |
This reverts commit cea12ab.
/merge |
Thanks all! 🙏 |
This PR updates `rapids_cpm_find` to force downloading of a package whenever a nonempty patch command exists. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Robert Maynard (https://github.com/robertmaynard) - Bradley Dice (https://github.com/bdice) URL: rapidsai#525
Description
This PR updates
rapids_cpm_find
to force downloading of a package whenever a nonempty patch command exists.Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)