Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nvtx3 build export #615

Merged
merged 4 commits into from
May 23, 2024

Conversation

trxcllnt
Copy link
Contributor

Description

Fixes the following error:

CMake Error at /home/coder/rmm/build/conda/cuda-12.2/latest/rmm-targets.cmake:52 (set_target_properties):
  The link interface of target "rmm::rmm" contains:
    nvtx::nvtx3-cpp
  but the target was not found.  Possible reasons include:
    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.
Call Stack (most recent call first):
  /home/coder/rmm/build/conda/cuda-12.2/latest/rmm-config.cmake:75 (include)
  build/conda/cuda-12.2/release/cmake/CPM_0.38.5.cmake:243 (find_package)
  build/conda/cuda-12.2/release/cmake/CPM_0.38.5.cmake:303 (cpm_find_package)
  build/conda/cuda-12.2/release/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:189 (CPMFindPackage)
  build/conda/cuda-12.2/release/_deps/rapids-cmake-src/rapids-cmake/cpm/rmm.cmake:75 (rapids_cpm_find)
  cmake/thirdparty/get_rmm.cmake:20 (rapids_cpm_rmm)
  cmake/thirdparty/get_rmm.cmake:24 (find_and_configure_rmm)
  CMakeLists.txt:192 (include)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@trxcllnt trxcllnt requested a review from a team as a code owner May 23, 2024 06:54
@trxcllnt trxcllnt added improvement Improves an existing functionality non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels May 23, 2024
@trxcllnt
Copy link
Contributor Author

I noticed we do this in RMM for spdlog, so maybe we should do that in rapids-cmake/cpm/spdlog.cmake instead?

@robertmaynard
Copy link
Contributor

I noticed we do this in RMM for spdlog, so maybe we should do that in rapids-cmake/cpm/spdlog.cmake instead?

There is an open issue to track that refactoring. #592 started down that path as part of the update to a newer spdlog version.

@robertmaynard
Copy link
Contributor

@trxcllnt I updated the PR to consistently use the name nvtx3 instead of NVTX3. Doing so makes the package logic consistent , and removes the need to do rapids_export_package(BUILD nvtx3 ${_RAPIDS_BUILD_EXPORT_SET} GLOBAL_TARGETS nvtx3-c nvtx3-cpp) as that is now properly done by rapids_cpm_find since it is given the corrected name.

Tested with a local rmm build tree and I see rmm the correct usage of the nvtx3 package in the rmm build tree.

@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 1ea1803 into rapidsai:branch-24.06 May 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants