Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistent spdlog dependency target no matter the source #1101

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Ensure consistent spdlog dependency target no matter the source #1101

merged 2 commits into from
Sep 28, 2022

Conversation

robertmaynard
Copy link
Contributor

Description

This removes the difference in targets generated for rmm depending on if spdlog is found on the machine, compared to being built as part of rmm.

Now in all cases rmm targets depend on spdlog::spdlog_header_only and never rmm::spdlog_header_only.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard
Ensure consistent spdlog dependency target no matter the source
3f77a07 
This removes the difference in targets generated for rmm depending
on if spdlog is found on the machine, compared to being built
as part of rmm.

Now in all cases rmm targets depend on `spdlog::spdlog_header_only`
and never `rmm::spdlog_header_only`.
@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for review Ready for review by team non-breaking Non-breaking change labels Sep 26, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner September 26, 2022 15:58
@github-actions github-actions bot added the CMake label Sep 26, 2022
@harrism
Copy link
Member

harrism commented Sep 28, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a60fb27 into rapidsai:branch-22.10 Sep 28, 2022
@robertmaynard robertmaynard deleted the bug/consistent_spdlog_target_no_matter_src branch September 28, 2022 12:09
@jameslamb jameslamb mentioned this pull request Apr 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for review Ready for review by team bug Something isn't working CMake non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @harrism @vyasr