Build C++ wheel #1529
Merged
Build C++ wheel #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
non-breaking
vyasr
added
feature request
This was referenced Apr 17, 2024
|
The pip devcontainer CI jobs will not pass until rapidsai/devcontainers#281 is merged I think, but everything else should (without this PR, once the devcontainers PR is merged I think both devcontainer jobs will start failing without this PR). Once this PR has all its approvals I'll merge that one and then rerun tests here. |
bdice
reviewed
May 3, 2024
wence-
approved these changes
May 3, 2024
raydouglass
approved these changes
May 3, 2024
|
/merge |
bdice
approved these changes
May 3, 2024
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
#1529 added new C++ wheels, but I forgot to update build.yaml there. Depends on rapidsai/shared-workflows#209. Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Ray Douglass (https://github.com/raydouglass) URL: #1554
rapids-bot bot
pushed a commit
that referenced
this pull request
May 6, 2024
Contributes to rapidsai/build-planning#30. Proposes adding the RAPIDS `verify-copyright` pre-commit hook, which automatically updates copyright dates for modified files. This also fixes one date in a file from #1529. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #1553
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
May 24, 2024
This PR uses `rapids-build-backend` to simplify wheel builds and reduce the complexity of various CI/build scripts. See also: - https://github.com/rapidsai/rapids-build-backend - rapidsai/build-planning#31 - rapidsai/cudf#15245 - #1529 Authors: - Bradley Dice (https://github.com/bdice) - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Vyas Ramasubramani (https://github.com/vyasr) URL: #1502
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
Jun 19, 2024
closes #250 I'm not sure if it makes sense to split the wheel into one dedicated wheel for the shared library, and another for the python wrapper. That's what @vyasr has been doing on other libraries, like rapidsai/rmm#1529. If it makes sense here, I'll add that. Authors: - Mike Sarahan (https://github.com/msarahan) - Philip Hyunsu Cho (https://github.com/hcho3) - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Ray Douglass (https://github.com/raydouglass) - Mads R. B. Kristensen (https://github.com/madsbk) - James Lamb (https://github.com/jameslamb) - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #369
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes wheel building in RMM to create a separate C++ wheel that is then found from the Python wheel. The C++ wheel is now a hard dependency of the Python wheel. This allows Python packaging to more closely mirror the structure of our conda packaging, and the way we would normally wish to package these in any other manager. It also allows us to reduce package sizes by allowing better sharing of artifacts between different Python packages that rely on the same C++ components from other packages.
Contributes to rapidsai/build-planning#33
Checklist