Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split up CUDA-suffixed dependencies in dependencies.yaml #1627

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. cudf depending on rmm, not rmm-cu12.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in dependencies.yaml.

For more details, see:

Notes for Reviewers

Why target 24.08?

This is targeting 24.08 because:

  1. it should be very low-risk
  2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 23, 2024
@github-actions github-actions bot added the Python Related to RMM Python API label Jul 23, 2024
@harrism
Copy link
Member

harrism commented Jul 23, 2024

It's a bit late for 24.08... better get it out of draft ASAP.

@jameslamb
Copy link
Member Author

It's a bit late for 24.08... better get it out of draft ASAP.

Yep understood! This should be ready to go, low-risk, and non-controversial... just opened it in draft until I could see CI pass, to minimize notifications for people.

Enough tests have passed that I'm confident in pulling this out of draft now. Hopefully the CI runners will work through their backlog soon 😬

@jameslamb jameslamb marked this pull request as ready for review July 24, 2024 02:33
@jameslamb jameslamb requested a review from a team as a code owner July 24, 2024 02:33
@jameslamb jameslamb changed the title WIP: split up CUDA-suffixed dependencies in dependencies.yaml split up CUDA-suffixed dependencies in dependencies.yaml Jul 24, 2024
@jameslamb
Copy link
Member Author

I've updated this based on the suggestions from rapidsai/cudf#16183.

Ran the following to check update-version.sh.

git fetch upstream --tags
ci/release/update-version.sh '24.10.00'

git grep -E '24\.8|24\.08|0\.39'

No changes to that script were needed.

packages:
- librmm-cu11==24.8.*,>=0.0.0a0
- matrix:
- matrix: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to be consistent about when we do and don't use inline tables (some of the other PRs for this did), but nbd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess in all those cases the package list only contained YAML anchors and not actual package specs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah exactly, that was the difference here.> inside a [] causes a YAML-parsing error, and when I surrounded this in single quotes that caused some of the pattern-matching in ci/release/update-version.sh to break. I thought just splitting it out to an indented map was simpler and safer than modifying update-version.sh to account for the possibility of quotes.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit e8df17d into rapidsai:branch-24.08 Jul 24, 2024
61 checks passed
@jameslamb jameslamb deleted the suffix-split branch July 24, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants