Move Python ucxx code into python/ucxx #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Assuming there's nothing missing (i.e., CI passes), LGTM. Thanks @KyleFromNVIDIA .
|
This will probably require a devcontainers change: https://github.com/rapidsai/devcontainers/blob/541895260fa9d3d772989c55c64a3ab98323f1c4/features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml#L42 cc @trxcllnt |
|
I've opened rapidsai/devcontainers#372 for this |
jameslamb
approved these changes
Jul 24, 2024
vyasr
approved these changes
Jul 24, 2024
|
/merge |
trxcllnt
added a commit
to rapidsai/devcontainers
that referenced
this pull request
Aug 1, 2024
Required for rapidsai/ucxx#252 Contributes to rapidsai/build-planning#33 --------- Co-authored-by: Paul Taylor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix up the isort configuration to get more correct results.
Contributes to rapidsai/build-planning#33