-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libucxx wheel #260
Add libucxx wheel #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These edits might get you on the right track. The argument that is cpp
or python
is backwards compatible, but if not present, it behaves as just python
, and the filenames don't line up.
Edit: for reference, here's where the bash script in action here lives: https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-upload-wheels-to-s3#L11, which eventually leads to the real difference in file naming: https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-package-name#L32
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @KyleFromNVIDIA .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments -- overall this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment on the impact on wheel sizes? LGTM.
Before this change: ucxx_cu12-0.40.0a14-cp311-cp311-manylinux_2_28_x86_64.whl - 5.2MB After this change: libucxx_cu12-0.40.0a32-py3-none-manylinux_2_24_x86_64.manylinux_2_28_x86_64.whl - 512KB As you can see, there is a 76% reduction in total wheel size. |
/merge |
*.pxd files were mistakenly removed in rapidsai#260. Resume installing them in the ucxx wheel.
`*.pxd` files were mistakenly removed in #260. Resume installing them in the ucxx wheel. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #270
Contributes to rapidsai/build-planning#33