Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rapids-cmake to pipeline #18

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 1, 2023

@bdice
Copy link
Contributor

bdice commented Jun 1, 2023

Let's wait to merge this until I can test rapids-core-dependencies downstream with rmm and add an actual dependency there.

@vyasr
Copy link
Contributor Author

vyasr commented Jun 2, 2023

Agreed, I don't have the ability to add labels here though so for now I'll just make this a draft.

@vyasr vyasr marked this pull request as draft June 2, 2023 18:55
@bdice
Copy link
Contributor

bdice commented Jul 24, 2023

@vyasr I discussed with @raydouglass and I think we want this to be in the nightly pipeline even if we don't use the rapids-core-dependencies package yet. We want rapids-cmake to run nightly tests, and running builds of rapids-core-dependencies won't hurt. Let's open this PR and see if we can get it merged. We'll follow up later in rapidsai/rmm#1307 once there is a hard dependency on rapids-core-dependencies to add rapids-cmake to the needs: list for rmm and other packages.

@vyasr vyasr marked this pull request as ready for review July 24, 2023 22:46
@vyasr
Copy link
Contributor Author

vyasr commented Jul 24, 2023

Sounds good. I've resolved the conflicts here and am happy to see this merged whenever.

@vyasr vyasr requested a review from bdice July 24, 2023 22:47
@raydouglass raydouglass merged commit a89e0ef into rapidsai:main Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants