fix: ListItemLink alignment #1088
Conversation
🦋 Changeset detectedLatest commit: 1f81f68 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1f81f68:
|
| @@ -186,7 +186,7 @@ const getProps = ({ | |||
| isVisited, | |||
| }) as IconProps['color'], | |||
| fontSize: size === 'medium' ? 100 : 75, | |||
| lineHeight: size === 'medium' ? 'm' : 's', | |||
| lineHeight: size === 'medium' ? 'l' : 's', | |||
There was a problem hiding this comment.
This was an incorrect implementation 🙈. It is l instead of m on Figma as well.
|
✅ PR title follows Conventional Commits specification. |
| children, | ||
| size, | ||
| }: { | ||
| children: (React.ReactChild | React.ReactFragment | React.ReactPortal)[]; |
There was a problem hiding this comment.
Any reason we kept this so specific? eg: Fragment, ReactPortal.
Can we use React.ReactNode instead?
There was a problem hiding this comment.
Had done it to suppress a warning. Made it ReactNode now. Draft PR hai, have mercy 😢
There was a problem hiding this comment.
lol sorry, was reviewing this at airport :p
chaitanyadeorukhkar
requested review from
dhruvdutt,
nashcheez,
divyanshu013 and
saurabhdaware
as code owners
React native has a vertical alignment bug that causes nested text which also has its own view inside to cause misalignment. This PR wraps all the children of list item (text and view) in a flex and aligns them.
Ref: facebook/react-native#31955
Before this PR:
After this PR:
