Skip to content

Commit

Permalink
Remove Danger from the development workflow (TextureGroup#1835)
Browse files Browse the repository at this point in the history
This has proven hard to maintain, and it has limited benefit now that
our CHANGELOG points to GitHub commit ranges.
  • Loading branch information
jparise authored and rcancro committed May 28, 2020
1 parent 6391b1d commit ce5fddf
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 120 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/danger.yml

This file was deleted.

83 changes: 0 additions & 83 deletions Dangerfile

This file was deleted.

4 changes: 0 additions & 4 deletions Gemfile

This file was deleted.

13 changes: 3 additions & 10 deletions build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ function build_example {
example="$1"

clean_derived_data

if [ -f "${example}/Podfile" ]; then
echo "Using CocoaPods"
pod install --project-directory=$example
Expand Down Expand Up @@ -92,13 +92,6 @@ tests|all)
success="1"
;;

danger|all)
bundle install
echo "Running Danger..."
bundle exec danger --fail-on-errors=true
success="1"
;;

tests_listkit)
echo "Building & testing AsyncDisplayKit+IGListKit."
pod install --project-directory=SubspecWorkspaces/ASDKListKit
Expand Down Expand Up @@ -253,7 +246,7 @@ cocoapods-lint-other-subspecs)

carthage|all)
echo "Verifying carthage works."

set -o pipefail && carthage update && carthage build --no-skip-current
success="1"
;;
Expand All @@ -263,7 +256,7 @@ carthage|all)
;;
esac

if [ "$success" = "1" ]; then
if [ "$success" = "1" ]; then
trap - EXIT
exit 0
fi

0 comments on commit ce5fddf

Please sign in to comment.