Fix contributing shellcheck #240
Conversation
@dckc Getting rid of them is the reason for #217. Help is needed to figure that out. #217 simplifies the re-implementation of the scripts, and the implementation of a non-developer interface for RGOV. |
| @@ -8,6 +8,8 @@ This project uses [```shellcheck```](https://github.com/koalaman/shellcheck) for | |||
| Shell script contributors using vscode are encouraged to install the vscode extension https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck. | |||
| ```shellcheck``` is also available in the Ubuntu package ```shellcheck``` | |||
|
|
|||
| [We](https://docs.google.com/document/d/1UfoBMB_OFm-pkjid0u9d0GddB2bWXjc8u-bo4Es0isU/edit#) also suggest all contributions should pass: | |||
There was a problem hiding this comment.
What is the relevance if rdev?
There was a problem hiding this comment.
Consult with @jimscarver for details abut the RDev reference.
There was a problem hiding this comment.
@jimscarver ? What is the relevance of rdev?
|
This seems to be merged without peer review. What motivated that? |
@dckc it's just a name for the branch - breaking it down semantically is unnecessary. |
#240 (review) resulted in face-to-face review with other RGOV members. I merged it out of convenience and consideration for other people's time. |
OK, so there was peer review. Cool. In the future, if you're acting on behalf of others, go ahead and make a note to leave an audit trail, please. |
|
the project is being performed by rdev decentralized governance. rdev is
the testbed for rgov.
…On Thu, Sep 9, 2021 at 10:27 PM Dan Connolly ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#240 (comment)>:
> @@ -8,6 +8,8 @@ This project uses [```shellcheck```](https://github.com/koalaman/shellcheck) for
Shell script contributors using vscode are encouraged to install the vscode extension https://marketplace.visualstudio.com/items?itemName=timonwong.shellcheck.
```shellcheck``` is also available in the Ubuntu package ```shellcheck```
+[We](https://docs.google.com/document/d/1UfoBMB_OFm-pkjid0u9d0GddB2bWXjc8u-bo4Es0isU/edit#) also suggest all contributions should pass:
@jimscarver <https://github.com/jimscarver> ? What is the relevance of
rdev?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXFQELQYZNPOY3ZLOLRBMTUBFUJBANCNFSM5AFWATUQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
While rdev is as welcome as anyone to use rgov, rgov is not in any way controlled or owned or subsumed by rdev. The project is being performed by its contributors. I thought I was pretty clear about this in the 2020-12-07 rdev meeting, though I evidently didn't manage to get it in the record. |
No description provided.