Help wanted to allow ballot-ui make use of participate.js

[David405]

No description provided.

[dckc]

This seems tricky... browsers don't grok bare-names like 'rchain-api'. Did you see errors in your browser console?

Or did you run this thru webpack somehow? How did you run this code?

[David405]

Yea, it couldn't find 'rchain-api' so I commented it out but it also couldn't find ./participate.js. I added ballot.html as an HTMLplugin in webpack

[dckc]

I'm confused... Are you saying you ran it with webpack or without? Or both?

If you saw browser console errors, what were they, exactly?

If you used webpack, exactly how did you start the code running? What characters did you type, exactly?

[David405]

As regarding webpack, I added ballot.html as an HTMLplugin. I ran the code using the normal npm run start

The error in the browser console is "cannot find http://localhost:8080/participate", I can't figure why it is looking for participate.js as a route rather than a js file

[dckc]

Ok, now you have given me enough info that I could test it on my end.

I just haven't managed to find time.

And it's not clear when I will. Such is life :-/

[David405]

How about over the weekend? Can you kindly make out time so we could go over this?

[dckc]

I'm out of town this weekend.

…

On Fri, Jul 23, 2021 at 2:28 PM David Asamonye ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/ballot-ui/ballot.js <#250 (comment)>: > @@ -0,0 +1,11 @@ + +import { getEthProvider } from 'rchain-api'; How about over the weekend? Can you kindly make out time so we could go over this? — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#250 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABE3SUMBMJV4ZZUDCSN72TTZG7GJANCNFSM5AOZY4CA> .

-- Dan Connolly http://www.madmode.com/

[David405]

The main problem I am facing is that I don't understand how participate.js interact with participate.html, I mean, when you do mount('#xxxx', xxxx) inside participate.js, how does participate.js know it has to search participate.html for #xxxxx?

If you can get me up to speed by explaining this, I think I can figure out a solution from there.

[David405]

@dckc I was able to figure out a fix, Idk if it's the best way to approach this but it works correctly and isn't causing any obvious problems.

What I did was, since I don't know how to make another HTML file use participate.js, I divided participate.html into two main divs (one div controls the developer interface, the other controls the voting interface) and created a navbar, the navbar buttons control which area of the DOM is shown or hidden, this way, I can use participate.html to render the voting interface.

[jimscarver]

src/MasterURI.localhost.json should not be committed

[David405]

I have fixed that, thanks for the catch.