-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help wanted to allow ballot-ui make use of participate.js #250
Conversation
src/ballot-ui/ballot.js
Outdated
@@ -0,0 +1,11 @@ | |||
|
|||
import { getEthProvider } from 'rchain-api'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems tricky... browsers don't grok bare-names like 'rchain-api'
. Did you see errors in your browser console?
Or did you run this thru webpack somehow? How did you run this code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it couldn't find 'rchain-api'
so I commented it out but it also couldn't find ./participate.js
. I added ballot.html
as an HTMLplugin
in webpack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused... Are you saying you ran it with webpack or without? Or both?
If you saw browser console errors, what were they, exactly?
If you used webpack, exactly how did you start the code running? What characters did you type, exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As regarding webpack, I added ballot.html
as an HTMLplugin.
I ran the code using the normal npm run start
The error in the browser console is "cannot find http://localhost:8080/participate", I can't figure why it is looking for participate.js
as a route rather than a js file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, now you have given me enough info that I could test it on my end.
I just haven't managed to find time.
And it's not clear when I will. Such is life :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about over the weekend? Can you kindly make out time so we could go over this?
I'm out of town this weekend.
…On Fri, Jul 23, 2021 at 2:28 PM David Asamonye ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/ballot-ui/ballot.js
<#250 (comment)>:
> @@ -0,0 +1,11 @@
+
+import { getEthProvider } from 'rchain-api';
How about over the weekend? Can you kindly make out time so we could go
over this?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#250 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABE3SUMBMJV4ZZUDCSN72TTZG7GJANCNFSM5AOZY4CA>
.
--
Dan Connolly
http://www.madmode.com/
|
The main problem I am facing is that I don't understand how If you can get me up to speed by explaining this, I think I can figure out a solution from there. |
@dckc I was able to figure out a fix, Idk if it's the best way to approach this but it works correctly and isn't causing any obvious problems. What I did was, since I don't know how to make another HTML file use |
src/MasterURI.localhost.json
Outdated
} | ||
|
||
{"localhostNETWORK": { "MasterURI": | ||
"`rho:id:nqdwznnpibxq1e3uaqdf473bfspsq7tueo5j34ncmb4g57o8z34ym4`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/MasterURI.localhost.json should not be committed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed that, thanks for the catch.
No description provided.