fix(meter): arbiter tick goroutine leak #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
napallday
changed the title
napallday
force-pushed
the
napallday/fix-arbiter-goroutine-leak
branch
from
3f7e0b2
to
094a979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arbiterwill tick periodically forever.Normally it wouldn't cause any issue.
But it's very inconvenient for users if Goroutine leak detector(like https://github.com/uber-go/goleak) is used in testing phase.
btw, I also change the nested lock in
arbiterfor better navigation.