Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't enforce dot after prefix #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Dieterbe
Copy link
Contributor

primary use case: if prefix == "" my metrics shouldn't start with a dot

primary use case: if prefix == "" my metrics shouldn't start with a dot
@mihasya
Copy link
Collaborator

mihasya commented Jul 6, 2015

I'd be worried about merging this, as anyone that's already running this with a prefix would suddenly have all their metrics change from foo.bar to foobar. Can you refactor this to be a bit more specific?

  • If the prefix is set to "", don't add the dot.
  • If the prefix is set to "foo", add a dot.
  • If the prefix is set to "foo.", do nothing.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants