🐞 #11106 fix disabled prop not update dirty formState (#11143)

* 🐞 #11106 fix disabled prop not update dirty formState * update test case * update to max 10kb
react-hook-form · Nov 5, 2023 · 30e5c42 · 30e5c42
1 parent 32f632a
commit 30e5c42
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -116,7 +116,7 @@
     "files": [
       {
         "path": "./dist/index.cjs.js",
-        "maxSize": "9.8 kB"
+        "maxSize": "10 kB"
       }
     ]
   },

diff --git a/src/__tests__/useForm/reset.test.tsx b/src/__tests__/useForm/reset.test.tsx
@@ -695,7 +695,7 @@ describe('reset', () => {
         expect(updatedDirtyFields).toEqual({
           firstName: true,
         });
-        expect(updatedDirty).toBeFalsy();
+        expect(updatedDirty).toBeTruthy();
 
         fireEvent.click(screen.getByRole('button', { name: 'submit' }));
 
@@ -849,7 +849,7 @@ describe('reset', () => {
         expect(updatedDirtyFields).toEqual({
           firstName: true,
         });
-        expect(updatedDirty).toBeFalsy();
+        expect(updatedDirty).toBeTruthy();
 
         fireEvent.click(screen.getByRole('button', { name: 'submit' }));
 

diff --git a/src/useForm.ts b/src/useForm.ts
@@ -107,6 +107,17 @@ export function useForm<
     [control, props.disabled],
   );
 
+  React.useEffect(() => {
+    if (control._proxyFormState.isDirty) {
+      const isDirty = control._getDirty();
+      if (isDirty !== formState.isDirty) {
+        control._subjects.state.next({
+          isDirty,
+        });
+      }
+    }
+  }, [control, formState.isDirty]);
+
   React.useEffect(() => {
     if (props.values && !deepEqual(props.values, _values.current)) {
       control._reset(props.values, control._options.resetOptions);