Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent insertion of nil values in the dictionary #328

Merged
merged 1 commit into from
Feb 15, 2018
Merged

fix: prevent insertion of nil values in the dictionary #328

merged 1 commit into from
Feb 15, 2018

Conversation

machour
Copy link
Collaborator

@machour machour commented Feb 15, 2018

Description

Fixed issues #39 and #89.

The problem was that nil was potentially inserted into the returned NSPlaceholderDictionary.

@machour machour added the ios label Feb 15, 2018
@machour
Copy link
Collaborator Author

machour commented Feb 15, 2018

@ahfarmer could you give this PR a review? (my first objective-c ever)

I safe guarded everything except:

  • isXXX that are booleans
  • currentDevice props (that cannot be nil)
  • boxed expressions (cause I understand that they don't return nil, right?)

Thank you!

@machour machour mentioned this pull request Feb 15, 2018
Closed
@andrewagain
Copy link
Contributor

@machour looks good to me!

@machour
Copy link
Collaborator Author

machour commented Feb 15, 2018

Thank you so much. Just tested this in an app, looks fine.

@machour machour merged commit b6b3b7f into master Feb 15, 2018
@machour machour deleted the fix-attempt-to-insert-nil branch February 15, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@machour @andrewagain