Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change incorrect OLD_ARCH header import #803

Merged
merged 1 commit into from
May 10, 2024

Conversation

svbutko
Copy link
Contributor

@svbutko svbutko commented May 10, 2024

Overview

The import was set incorrectly for OLD_ARCH which leads to project's failing build.

Test Plan

Build an iOS project with OLD_ARCH.

@svbutko svbutko requested a review from Naturalclar as a code owner May 10, 2024 11:50
@svbutko svbutko changed the title Update old arch header import Update OLD_ARCH header import May 10, 2024
@svbutko svbutko changed the title Update OLD_ARCH header import Change incorrect OLD_ARCH header import May 10, 2024
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Naturalclar Naturalclar merged commit 748a7aa into react-native-menu:master May 10, 2024
@robertherber
Copy link

robertherber commented May 10, 2024

@Naturalclar how soon is it possible with a new release including this? :)

Edit: I see now that I was a minute late to ask for it, thanks! 🥳

@Naturalclar
Copy link
Member

@robertherber just released a new version! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants