Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS building on CI #806

Merged
merged 9 commits into from
May 11, 2024
Merged

Conversation

svbutko
Copy link
Contributor

@svbutko svbutko commented May 10, 2024

Overview

  • Removed unwanted lock files
  • Updated react-native-test-app to fix issues with Embed Manifest failing to find app.json

In order to work in CI, next changes needs to be added to ci.yml for Build example app:

run: cd example/ios && xcodebuild -workspace MenuExample.xcworkspace -scheme MenuExample -destination "platform=iOS Simulator,id=F882DE2D-825C-4D22-A66D-682FCF5FCCF8" CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NO -skip-testing:ReactTestAppTests/ReactNativePerformanceTests

@svbutko svbutko requested a review from Naturalclar as a code owner May 10, 2024 16:55
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Naturalclar Naturalclar merged commit ba07977 into react-native-menu:master May 11, 2024
@svbutko
Copy link
Contributor Author

svbutko commented May 11, 2024

@Naturalclar the git hook is also has to be changed in order to work as I mentioned in description, I unfortunately can't change it, only authorized author can adjust it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants