Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate: useTransition #609

Merged
merged 5 commits into from
May 14, 2023
Merged

Translate: useTransition #609

merged 5 commits into from
May 14, 2023

Conversation

1ilsang
Copy link
Contributor

@1ilsang 1ilsang commented May 1, 2023 •
edited
Loading

hg-pyun
hg-pyun reviewed May 5, 2023
View reviewed changes
src/content/reference/react/useTransition.md Show resolved Hide resolved
src/content/reference/react/useTransition.md
@@ -893,9 +893,9 @@ b { display: inline-block; margin-right: 10px; }

</Sandpack>

Hiding the entire tab container to show a loading indicator leads to a jarring user experience. If you add `useTransition` to `TabButton`, you can instead indicate display the pending state in the tab button instead.
로딩 표시기를 표시하기 위해 전체 탭 컨테이너를 숨기면 사용자 경험이 어색해집니다. `TabButton`에 `useTransition`을 추가하면 탭 버튼에 보류 중인 상태를 표시할 수 있습니다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위 로딩 표시기와 동문

@gnujoow
Copy link
Member

gnujoow commented May 9, 2023 •
edited
Loading

@1ilsang
Copy link
Contributor Author

1ilsang commented May 9, 2023

@gnujoow 님 반영되었습니다

@1ilsang 1ilsang requested a review from hg-pyun May 9, 2023 12:53
gnujoow
gnujoow requested changes May 9, 2023
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역 제안은 대부분 정확하고 자연스러운 표현을 사용하고 있습니다. 다만 일부 표현에서 수정되면 이해를 더 쉽게할 수 있는 부분들이 더 있는것 같습니다. 제안해주신 문서를 한번 다시 확인해주시고 이해하기 쉬운 표현으로 바꿔주시면 더 좋을것 같습니다.

src/content/reference/react/useTransition.md Outdated
Comment on lines 44 to 45
1. 보류 중인 transition이 있는지를 알려주는 `isPending` 플래그입니다.
2. state 업데이트를 transition으로 표시할 수 있는 [`startTransition` 함수](#starttransition)입니다.
Copy link
Member

@gnujoow gnujoow May 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. 보류 중인 transition이 있는지를 알려주는 `isPending` 플래그입니다.
2. state 업데이트를 transition으로 표시할 수 있는 [`startTransition` 함수](#starttransition)입니다.
1. `isPending` 플래그는 대기 중인 transition이 있는지 알려줍니다.
2. [`startTransition` 함수](#starttransition)는 상태 업데이트를 transition으로 표시할 수 있게 해주는 함수입니다.

위 문장들은 useTranstion의 반환값 대해서 안내합니다. 각 아이템들이 주어가 되는 번역이 의미를 더 잘 전달합니다.

src/content/reference/react/useTransition.md Outdated

Call `useTransition` at the top level of your component to mark state updates as non-blocking *transitions*.
컴포넌트의 최상위 수준에서 `useTransition`을 호출하여 state 업데이트를 non-blocking *transitions*으로 표시하세요.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
컴포넌트의 최상위 수준에서 `useTransition`을 호출하여 state 업데이트를 non-blocking *transitions*으로 표시하세요.
컴포넌트의 최상위 레벨에서 `useTransition`을 호출하여 state 업데이트를 non-blocking *transitions*으로 표시하세요.

수준이라는 표현이 중의적으로 해석될수 있는 여지가 있습니다. 컴포넌트의 위계를 설명하므로 레벨로 음차하는것이 의미 전달을 더 잘한다고 생각합니다.

@github-actions
Copy link

github-actions bot commented May 10, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@1ilsang 1ilsang mentioned this pull request May 11, 2023
Closed
1 task
@1ilsang
Copy link
Contributor Author

1ilsang commented May 11, 2023

@gnujoow 님 리뷰 반영했습니다

@eomttt eomttt requested a review from gnujoow May 13, 2023 02:36
hg-pyun
hg-pyun approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hg-pyun hg-pyun enabled auto-merge (squash) May 14, 2023 05:59
@hg-pyun hg-pyun disabled auto-merge May 14, 2023 05:59
@hg-pyun hg-pyun merged commit 1b5f24b into reactjs:main May 14, 2023
@tmair32 tmair32 mentioned this pull request Jun 29, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@eomttt eomttt eomttt approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno taehwanno is a code owner

@simsim0709 simsim0709 Awaiting requested review from simsim0709 simsim0709 is a code owner

@b9words b9words Awaiting requested review from b9words b9words is a code owner

@taggon taggon Awaiting requested review from taggon taggon is a code owner

@MaxKim-J MaxKim-J Awaiting requested review from MaxKim-J MaxKim-J is a code owner

@goofcode goofcode Awaiting requested review from goofcode

@gnujoow gnujoow Awaiting requested review from gnujoow gnujoow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@1ilsang @gnujoow @hg-pyun @eomttt