Add nested TabList and TabPanel support #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fixed version of #180.
I created two specialized functions to deeply map and forEach react children. This functions will only call the callback for the react-tabs elements and also not go deeper when it reaches the first Tab or TabPanel.
This also already allows custom elements inside TabList, although it does not yet make sense as TabList is rendered as
<ul>and Tab as<li>, but I want to change this so that there is an option to change the tag type maybe.@McPo If you have time could you take a look and tell me if that looks good? And/Or maybe test with your usecase?