Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-expanded attribute #71

Closed
wants to merge 2 commits into from
Closed

Conversation

cannona
Copy link

@cannona cannona commented Feb 2, 2016

The aria-expanded attribute is redundant here, as the natural state of a selected tab is expanded. It also causes the Jaws screen reader to read each tab, as it is arrowed to, strangely.

The aria-expanded attribute is redundant here, as the natural state of a selected tab is expanded.  It also causes the Jaws screen reader to read each tab, as it is arrowed to, strangely.
@cannona
Copy link
Author

cannona commented Feb 2, 2016

Sorry, that should have been "read each tab strangely, as it is navigated to via the arrow keys."

@danez
Copy link
Collaborator

danez commented Jun 27, 2016

Thanks for your contribution.

Could you please rebase your changes?

danez added a commit that referenced this pull request Jul 5, 2016
@danez
Copy link
Collaborator

danez commented Jul 5, 2016

Closed via 9fbdb80

@danez danez closed this Jul 5, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants