Add translation for "Importing and Exporting Components" page #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadym-oliinyk
commented
May 11, 2023
|
|
||
| Move the `Profile` component to its own `Profile.js`, and then change the `App` component to render both `<Profile />` and `<Gallery />` one after another. | ||
| Ви можете використовувати як дефолтний, так і іменований експорт для `Profile`, проте переконайтеся, що використовуєте відповідний синтаксис імпорту як в `App.js`, так і в `Gallery.js`! Ви можете скористатися таблицею з розділу про поглиблений аналіз вище: |
There was a problem hiding this comment.
Тут "deep dive" переклав як "поглиблений аналіз". Але не впевнений, що це доречно для цього глобального компоненту
vadym-oliinyk
commented
May 11, 2023
| * How to split components into multiple files | ||
| * Що таке файл кореневого компонента | ||
| * Як імпортувати та експортувати компонент | ||
| * Коли використовувати дефолтні та іменовані імпорти та експорти |
There was a problem hiding this comment.
По всьому тексту переклав "default exports" як "дефолтні експорти", а не "експорти за замовчуванням". Чи це окей?
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
reviewed
May 24, 2023
bkatsevych
approved these changes
May 25, 2023
|
Гарна робота! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
@bkatsevych дякую! внести ті корективи, що в коментарях вище? чи вони вже resolved бо не актуальні?) |
|
@vadym-oliinyk Після ревʼю, ваші + мої корективи вступають в силу, перед тим як замержити PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.