Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflowable document viewport gets clipped when enlarged (CSS columns) #181

Open
danielweck opened this issue May 5, 2015 · 11 comments
Open

Comments

@danielweck
Copy link
Member

Originally posted here:
http://idpf.org/forum/topic-2430

By http://idpf.org/users/elania
Elania (Alex)

"
When I have a book open and the new window is fullscreen, a little bit of the left-hand side text is cut off. It's still technically readable, but it makes it much more difficult and is very annoying.

It doesn't do this if I make the screen small enough, but if I have to have it in a separate window, I want to at least have it as large as possible.
"

readium error

@rkwright
Copy link
Member

rkwright commented May 6, 2015

This is also reproducible with the current release (0.18 in master) on OSX with SmokeTestFXL.epub

@danielweck
Copy link
Member Author

@rkwright on a fixed-layout (pre-paginated) spine item, or a reflowable document?

@rkwright
Copy link
Member

rkwright commented May 6, 2015

I have been able to reproduce only in fixed layout. Reflowable (in my limited testing) seems fine.

@theWhiteFox
Copy link

I have the same issue, my workaround is to change layout to document. Unfortunately doing this only displays a single page, however it least the page is not cropped.

@johanpoirier
Copy link

Some people in my company have the same issue but I haven't be able to observe it on my own laptop (MacBook Air).

@johanpoirier
Copy link

I located the bug.

The column width is computed with a Math.round():

And when we compute the page offset, we use the rounded value of the column width:
https://github.com/readium/readium-shared-js/blob/develop/js/views/reflowable_view.js#L456

I think of 2 solutions:

  • do not round the columnWidth value and round the pageOffset value instead
  • store in paginationInfo the exact value: paginationInfo.exactColumnWidth

Any thoughts?

@danielweck
Copy link
Member Author

To those of you following this discussion thread, @johanpoirier kindly looked into this rounding issue, and has run some tests: #188 (comment)

@danielweck
Copy link
Member Author

More screenshots from @thiagoeec here: readium/readium-js-viewer#344

matwood pushed a commit to bibliolabs/readium-shared-js that referenced this issue Jul 15, 2015
matwood pushed a commit to bibliolabs/readium-shared-js that referenced this issue Jul 15, 2015
matwood pushed a commit to bibliolabs/readium-shared-js that referenced this issue Jul 15, 2015
@vamsundar
Copy link

Still we are facing this issue, is there any update on this issue...

untitled

@jccr
Copy link
Member

jccr commented Aug 10, 2015

Oh I re-opened this one, and wrote comments:
#37

They look like the same issue to me.

@danielweck
Copy link
Member Author

Similar (identical) issue? #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants