fix: Set proper notfound_urls_prefix option types (#233)

* fix: Set proper `notfound_urls_prefix` option types * feat(tests): Simplify * chore: restore lines * again --------- Co-authored-by: Manuel Kaufmann <[email protected]>
readthedocs · May 23, 2024 · 3032721 · 3032721
1 parent bbc8127
commit 3032721
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/notfound/extension.py b/notfound/extension.py
@@ -299,6 +299,7 @@ def setup(app):
             default_version=default_version,
         ),
         'html',
+        types=[str, type(None)],
     )
 
     app.connect('config-inited', validate_configs)

diff --git a/tests/test_urls.py b/tests/test_urls.py
@@ -196,6 +196,8 @@ def test_urls_prefix_setting_none(app, status, warning):
     for chunk in chunks:
         assert chunk in content
 
+    assert "The config value `notfound_urls_prefix' has type `NoneType', defaults to `str'" not in warning.getvalue()
+    assert "build succeeded." in status.getvalue()
 
 @pytest.mark.sphinx(
     srcdir=srcdir,