Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on sphinx 2.2.0 #72

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Test on sphinx 2.2.0 #72

merged 1 commit into from
Sep 24, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 5, 2019

Remove bugfixing releases from Tox and add Sphinx 2.2

@humitos humitos requested a review from a team September 5, 2019 21:08
sphinx18: sphinx==1.8.5
sphinx20: sphinx==2.0.1
sphinx21: sphinx==2.1.2
sphinx22: sphinx==2.2.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little easier and not a problem with this PR, but these specifiers could be more general:

sphinx17: sphinx<1.8
sphinx18: sphinx<1.9

etc. This removes the need to update these versions manually and catches backport releases and new releases if we're falling behind and not updating.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Noted a future change to make maintenance easier.

@agjohnson agjohnson merged commit 5a89ba8 into master Sep 24, 2019
@agjohnson agjohnson deleted the humitos/test-on-sphinx-2.2.0 branch September 24, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants