add fix for protected parent

rectorphp · May 30, 2024 · eb46e12 · eb46e12
1 parent 2774024
commit eb46e12
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/Command/PrivatizeConstantsCommand.php b/src/Command/PrivatizeConstantsCommand.php
@@ -134,6 +134,7 @@ private function runPHPStanAnalyse(array $paths): array
     private function replacePrivateConstWith(ClassConstMatch $publicClassConstMatch, string $replaceString): void
     {
         $classFileContents = FileSystem::read($publicClassConstMatch->getClassFileName());
+
         // replace "private const NAME" with "private const NAME"
         $classFileContents = str_replace(
             'private const ' . $publicClassConstMatch->getConstantName(),
@@ -142,5 +143,9 @@ private function replacePrivateConstWith(ClassConstMatch $publicClassConstMatch,
         );
 
         FileSystem::write($publicClassConstMatch->getClassFileName(), $classFileContents);
+
+        // @todo handle case when "AppBundle\Rpc\BEItem\BeItemPackage::ITEM_TYPE_NAME_PACKAGE" constant is in parent class
+        $parentClassConstMatch = $publicClassConstMatch->getParentClassConstMatch();
+        $this->replacePrivateConstWith($parentClassConstMatch, $replaceString);
     }
 }
diff --git a/src/ValueObject/ClassConstMatch.php b/src/ValueObject/ClassConstMatch.php
@@ -36,4 +36,14 @@ public function getClassFileName(): string
         $classReflection = new ReflectionClass($this->className);
         return (string) $classReflection->getFileName();
     }
+
+    public function getParentClassConstMatch(): ?self
+    {
+        $classReflection = new ReflectionClass($this->className);
+        if ($classReflection->getParentClass() === false) {
+            return null;
+        }
+
+        return new self($classReflection->getParentClass()->getName(), $this->constantName);
+    }
 }