Object autocompletion in arrays with custom indentation produces invalid output

[TedDriggs]

Describe the bug

I have a YAML file with a schema defined in .vscode/settings.json, along with a custom YAML setting of editor.tabSize: 4. When I use the array autocompletion, the following happens:

I believe that the generated keys have gone one indentation deeper than their parent, without realizing that an array parent only goes in two spaces.

Expected Behavior

The model, weight, and criteria keys should be aligned with id.

Current Behavior

See screenshot

Steps to Reproduce

1. Set .vscode/settings.json with a YAML override, as described above
2. Create a schema with an array of objects
3. Attempt to add an item to the list

Environment

• Windows
• Mac
• Linux
• other (please specify)

[evidolob]

@TedDriggs Can you share JSON Schema that you used? I cannot reproduce this with my schemas.

[TedDriggs]

Here's the one for the file where the error was taking place

{
    "additionalProperties": {
        "properties": {
            "field": {
                "type": "string"
            },
            "variants": {
                "type": "array",
                "items": {
                    "$ref": "#/definitions/variant",
                    "uniqueItems": true
                }
            },
            "default": {
                "$ref": "#/definitions/variant"
            },
            "inputs": {
                "type": "object",
                "additionalProperties": {
                    "type": "object",
                    "additionalProperties": {
                        "$ref": "#/definitions/variant"
                    }
                }
            },
            "rules": {
                "type": "array",
                "items": {
                    "$ref": "./rules.schema.json#/definitions/rule"
                }
            }
        },
        "required": ["field", "variants", "inputs", "rules"]
    },
    "definitions": {
        "variant": {
            "type": "string",
            "pattern": "[a-z][a-z\\d_]*"
        }
    }
}

And here's the referenced rules.schema.json.

{
    "type": "array",
    "items": {
        "$ref": "#/definitions/rule"
    },
    "definitions": {
        "rule": {
            "type": "object",
            "properties": {
                "id": {
                    "type": "string"
                },
                "notes": {
                    "type": "string"
                },
                "links": {
                    "type": "array",
                    "items": {
                        "properties": {
                            "rel": {
                                "type": "string"
                            },
                            "url": {
                                "type": "string"
                            }
                        }
                    }
                },
                "nomination": {
                    "type": "string",
                    "pattern": "[a-z0-9_]+"
                },
                "weight": {
                    "type": "number",
                    "minimum": 1
                },
                "criteria": {
                    "type": "array",
                    "minItems": 1,
                    "items": {
                        "type": "object",
                        "properties": {
                            "field": {
                                "type": "string"
                            },
                            "operator": {
                                "type": "string"
                            },
                            "operand": {
                                "type": "string"
                            }
                        },
                        "required": ["field", "operator", "operand"],
                        "additionalProperties": false
                    }
                }
            },
            "required": ["id", "weight", "criteria", "nomination"]
        }
    }
}

And then here's the .vscode/settings.json file I'm using:

{
    "yaml.schemas": {
        "./schemas/runoffs.schema.json": ["*.runoffs.yaml"]
    },
    "[yaml]": {
        "editor.tabSize": 4
    }
}