Add title to extension configuration #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [VSCode configuration schema](https://code.visualstudio.com/api/references/contribution-points#Configuration-schema), the `.contributes.configuration.title` property seems to be required and is currently missing in vscode-yaml.
fbricon
approved these changes
Jul 8, 2022
gorkem
approved these changes
Jul 9, 2022
msivasubramaniaan
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
According to the VSCode configuration schema, the
.contributes.configuration.titleproperty seems to be required and is currently missingin vscode-yaml. This PR adds the title to configuration.
What issues does this PR fix or reference?
None
Is it tested? How?
npm installnpm run buildvsce packageThen add
.vsixto VSCode, made sure extension still works on YAML and I verified configuration still has the YAML settings there (and only once). Also clicked the 'extension settings' from the extensions list and I also got to all the YAML settings.