Handle less-specified initialization #193
Conversation
|
Yeah, i suppose this would change branch coverage... I don't readily see where to inject a different capabilities in the test suite to try it out. Any thoughts? |
|
There isn't anywhere currently that would allow you to write a test for the initialization properties AFAIK. I've tested in vscode and also neovim (though I only was able to get diagnostics to work but thats probably more of a me issue) and everything seems good to me. Were you testing your changes in neovim? |
|
That's what I meant about "not a user"... Just trying to help out!
…On Mon, Oct 21, 2019, 16:00 Josh Pinkney ***@***.***> wrote:
There isn't anywhere currently that would allow you to write a test for
the initialization properties AFAIK.
I've tested in vscode and also neovim (though I only was able to get
diagnostics to work but thats probably more of a me issue) and everything
seems good to me.
Were you testing your changes in neovim?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#193?email_source=notifications&email_token=AAALCRDTGUQ7UW3Z562X5IDQPYC4RA5CNFSM4JCWXGI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB3TCOA#issuecomment-544682296>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRDSX3BO4UP55NLSNODQPYC4RANCNFSM4JCWXGIQ>
.
|
|
@pappasam Do you mind trying this out just to make sure everything is working on your side? If it is, I'll do a release either the 30th or the 31st with the fixes! |
|
🎃
To hit the coverage, I could refactor the initialization piece into a
standalone function/file and just test that with some degenerate cases....
…On Tue, Oct 22, 2019, 08:52 Josh Pinkney ***@***.***> wrote:
@pappasam <https://github.com/pappasam> Do you mind trying this out just
to make sure everything is working on your side? If it is, I'll do a
release either the 30th or the 31st with the fixes!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#193?email_source=notifications&email_token=AAALCRCGLW2H4M7MBZRJ3GLQP3ZSDA5CNFSM4JCWXGI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB5TX5Y#issuecomment-544947191>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRBT5775VFEVEKMCEQLQP3ZSDANCNFSM4JCWXGIQ>
.
|
|
@JPinkney I confirm this PR fixes the issue for me! |
|
Thanks for your contribution! |
|
Hooray!
|
|
@JPinkney when this is part of a release, I'll update the LanguageClient-neovim's documentation to remove the version constraint: https://github.com/autozimu/LanguageClient-neovim/wiki/yaml-language-server#requirements |
For #192.
Clients need not specify textDocument or workspace capabilities when initializing (spec).
This PR handles these potentially absent values with
an existence check and a touch of destructuring and default valuesreally long existence check chains.