Made yamlSchemaService accept multiple uris from requestCustomSchema #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
suggested changes
Jan 27, 2020
JPinkney
force-pushed
the
multiple-custom-schemas
branch
2 times, most recently
from
615001b
to
1def887
Compare
gorkem
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the customSchemaProvider to receive multiple uri's, load them, and combine them into one giant schema. The giant schema is a oneOf schema. This technically means that multiple contributors can match a specific file and send a schema back to the language server but only the schema that's matching the current file contents will be used!