Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with @ symbol in relative path #254

Merged

Conversation

levrado
Copy link
Contributor

@levrado levrado commented Apr 21, 2020

when trying to add a schema from a scoped package: ./node_modules/@amenity/schemas/myschema.json, isRelativePath returns false and the server issues the following error: Unable to load schema from '/./node_modules/...

the fix: add @ to regex pattern

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.223% when pulling 36c549d on levrado:fix_bug_with_scoped_package_path into 7a66d53 on redhat-developer:master.

@JPinkney JPinkney merged commit 2807bed into redhat-developer:master Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants