Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle workspace folders better #281

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Handle workspace folders better #281

merged 2 commits into from
Jul 17, 2020

Conversation

JPinkney
Copy link
Contributor

This PR serves a few purposes:

  1. Handle multi-root workspaces better by looking for onDidChangeWorkspaceFolder events
  2. Fix a bug where if you have a workspace like test with yaml file test underneath it:
test:
   test.yaml

the yaml file wouldn't correctly associate with a schema.
3. If a language client doesn't send workspace folders in initialization it will allow the relative path resolver to pick workspaceFolders up after and use those for relative path resolution.

…after the Language Server has started.

Previously, the language server would only use workspaceFolders if it was passed in on initialization

Signed-off-by: Josh Pinkney <[email protected]>
@JPinkney JPinkney merged commit 7346049 into master Jul 17, 2020
@evidolob evidolob deleted the workspace-folders branch August 11, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant