Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yaml-language-server to be compatible with vscode-json-languag… #350

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Update yaml-language-server to be compatible with vscode-json-languag… #350

merged 4 commits into from
Nov 12, 2020

Conversation

JPinkney
Copy link
Contributor

…eservice 3.10.0

Signed-off-by: Josh Pinkney [email protected]

What does this PR do?

This PR updates yaml ls to be compatible with the newest version of vscode-json-languageservice.
Notable changes:

  • Removes completion resolve since it doesn't actually do anything
  • Maintains findDefinition when using this project as a library but makes it return [], just for compatibility reasons (vscode-json-languageservice does this as well)
  • Implements findLinks based off of the newest vscode-json-languageservice which returns all document links in the document

What issues does this PR fix or reference?

#345

Is it tested? How?

npm run test

@JPinkney
Fixup
c9a921d 
Signed-off-by: Josh Pinkney <[email protected]>
@coveralls
Copy link

coveralls commented Nov 12, 2020 •
edited
Loading

Coverage Status

Coverage increased (+1.0%) to 78.823% when pulling 6c5b1b3 on fix-json-ls-compat into 5c483ee on master.

@JPinkney
Fixup
6c5b1b3 
Signed-off-by: Josh Pinkney <[email protected]>
@JPinkney JPinkney merged commit 35e3358 into master Nov 12, 2020
@JPinkney JPinkney deleted the fix-json-ls-compat branch November 12, 2020 14:56
@marcusramberg
Copy link

Any plans for a new release to get this fix out?

@evidolob evidolob mentioned this pull request Nov 19, 2020
Closed
@evidolob
Copy link
Collaborator

@marcusramberg I will start bugfix release in a few hours.

@JPinkney
Copy link
Contributor Author

Should we do bugfix release or full release? Since 4708ed0 and 6024f9a are new features

@evidolob
Copy link
Collaborator

Then full release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuawilson joshuawilson joshuawilson approved these changes

@evidolob evidolob Awaiting requested review from evidolob evidolob is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JPinkney @coveralls @marcusramberg @evidolob @joshuawilson