Remove unneeded promise constructors #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Pinkney <[email protected]>
evidolob
approved these changes
Nov 12, 2020
| @@ -5,7 +5,7 @@ | |||
| *--------------------------------------------------------------------------------------------*/ | |||
| 'use strict'; | |||
|
|
|||
| import { PromiseConstructor, Thenable } from 'vscode-json-languageservice'; | |||
| import { Thenable } from 'vscode-json-languageservice'; | |||
There was a problem hiding this comment.
I don't think you need Thenable either.
| @@ -10,7 +10,7 @@ import { ASTNode, ObjectASTNode, PropertyASTNode } from '../jsonASTTypes'; | |||
| import { parse as parseYAML } from '../parser/yamlParser07'; | |||
| import { YAMLSchemaService } from './yamlSchemaService'; | |||
| import { JSONSchema, JSONSchemaRef } from '../jsonSchema'; | |||
| import { PromiseConstructor, Thenable, JSONWorkerContribution, CompletionsCollector } from 'vscode-json-languageservice'; | |||
| import { Thenable, CompletionsCollector } from 'vscode-json-languageservice'; | |||
There was a problem hiding this comment.
Don't need Thenable here either.
|
I guess I can stop reviewing this. :-) |
|
I'm going to make another PR that switches all Thenable to Promise 😄 |
|
You promise? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney [email protected]
What does this PR do?
This PR removes promise constructors since they aren't actually used anywhere. We've always just used Promise and never passed anything different in
What issues does this PR fix or reference?
Is it tested? How?
npm run test