Check if dynamic registration is enabled before executing onDidChangeWorkspaceFolders #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WorkspaceFolders Signed-off-by: Josh Pinkney <[email protected]>
Signed-off-by: Josh Pinkney <[email protected]>
joshuawilson
approved these changes
Dec 15, 2020
|
@JPinkney I can't think of how to test this but I'm going to ask anyway, is there a way to write a test that covers this? |
Not currently, I have some code that completely refactors the language server so that you can test almost everything but I won't have it fully ready until friday-ish |
|
I figured as much, that is why I approved without requiring the test. |
evidolob
approved these changes
Dec 16, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney [email protected]
What does this PR do?
It seems that vscode-languageserver automatically sends a
client/registerCapabilityto the client if you useonDidChangeWorkspaceFolderson the server side. This means that currently the server will then sendclient/registerCapabilityeven if the client doesn't support it. Since workspaceFolders don't have dynamicRegistration in the initialization according to the LSP spec, there's no way to tell if we should be usingonDidChangeWorkspaceFoldersand thus sending theclient/registerCapabilityon the server side. This PR makes it so thatonDidChangeWorkspaceFoldersis only registered when the formatter dynamic registration is availableWhat issues does this PR fix or reference?
#370
#377
Is it tested? How?