-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix array new line ending with no indent #384
Fix array new line ending with no indent #384
Conversation
@JPinkney Sorry for wrong problem detection. Update: it's more about inserting 'holder' into right position instead of bug in yaml-ast-parser in this example: - item: 1
| #cursor here
node: 2 it puts 'holder' inside the it's true that in yaml-ast-parser:
I will delete PR on yaml-ast-parser repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I tested it and everything looks to be working correctly!
What does this PR do?
fix array new line ending with no indent
This 'bug' can be observe by code completion in this scenario:
Array:
bug.description.mov
What issues does this PR fix or reference?
p-spacek#1
Expected Behavior
This is expected behavior - fixed in yaml-ast-parser
after.fix.mov
Is it tested? How?
this merge contains only unit test.
real PR fix is on repository yaml-ast-parser
redhat-developer/yaml-ast-parser#15