Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array new line ending with no indent #384

Conversation

p-spacek
Copy link
Contributor

What does this PR do?

fix array new line ending with no indent

This 'bug' can be observe by code completion in this scenario:
Array:

bug.description.mov

What issues does this PR fix or reference?

p-spacek#1

Expected Behavior

This is expected behavior - fixed in yaml-ast-parser

after.fix.mov

Is it tested? How?

this merge contains only unit test.
real PR fix is on repository yaml-ast-parser
redhat-developer/yaml-ast-parser#15

@coveralls
Copy link

coveralls commented Dec 30, 2020

Coverage Status

Coverage increased (+0.02%) to 81.091% when pulling 2c7951e on p-spacek:fix/array-newLine-ending-with-no-indent into 9013b60 on redhat-developer:master.

@p-spacek
Copy link
Contributor Author

@JPinkney Sorry for wrong problem detection.

Update: it's more about inserting 'holder' into right position instead of bug in yaml-ast-parser

in this example:

  - item: 1
 
| #cursor here
node: 2

it puts 'holder' inside the node: 2

it's true that in yaml-ast-parser:

  • array takes all empty symbols
  • object doesn't

I will delete PR on yaml-ast-parser repository.

Copy link
Contributor

@JPinkney JPinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I tested it and everything looks to be working correctly!

@JPinkney JPinkney merged commit aaf4228 into redhat-developer:master Jan 11, 2021
@JPinkney JPinkney mentioned this pull request Jan 11, 2021
@p-spacek p-spacek deleted the fix/array-newLine-ending-with-no-indent branch January 11, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants